Taxonomy depth and autofocus fix#2976
Conversation
|
Thanks for the pull request, @jesperhodge! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
Reason for closing: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2976 +/- ##
==========================================
- Coverage 95.56% 95.56% -0.01%
==========================================
Files 1349 1349
Lines 31159 31234 +75
Branches 6833 6853 +20
==========================================
+ Hits 29777 29848 +71
- Misses 1332 1336 +4
Partials 50 50 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Note on unit testing
I have decided against additional unit tests because:
I have no strong opinion on this whatsoever. If you want tests, let me know and I'll write tests.
Testing instructions
Go to a taxonomy
Create nested subtags 6 levels deep (count from top to innermost tag - sum should be 6 levels)
You should not encounter an error
All levels should have an expand/collapse icon and a menu with Add Subtag and Rename actions
Only on the innermost level (that should be the 6th level) the Add Subtag action should be disabled
Reload page
New tags now appear alphabetically ordered (they have been refreshed from server)
You should see all 6 levels on expanding them
Innermost level (6th level) should have the Add Subtag action disabled and should not have a collapse/expand icon
Create any new tag
Autofocus should automatically move the cursor to the input field
type in any single character
that character should not be highlighted
type in more characters
since the first character was not highlighted, new character should not overwrite previous one
Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypesanddefaultPropsin any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../in import paths. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'